Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| [features] | ||
| default = ["ffi", "semaphore"] | ||
| default = ["semaphore"] | ||
| semaphore = ["walletkit-core/semaphore"] |
There was a problem hiding this comment.
The new World ID 4.0 Authenticator lives behind walletkit-core’s v4 feature, but walletkit depends on walletkit-core with default-features = false (workspace Cargo.toml) and only forwards the semaphore feature here. As a result, building walletkit with its default feature set (e.g., via build_swift.sh or cargo build) does not enable walletkit-core/v4, so the Authenticator/world-id-core APIs introduced in this commit are never compiled into the exported FFI bindings. If the goal is to ship the new protocol, walletkit needs to forward the v4 feature (or stop disabling walletkit-core defaults), otherwise downstream consumers still get the pre-v4 surface.
Useful? React with 👍 / 👎.
2 participants
This is an ongoing branch.